[PATCH] D108525: Fix documentation and snippets for the handle attributes.

aaron.ballman closed this revision. aaron.ballman added a comment. In D108525#2960903 , @paulherman wrote: > In D108525#2960877 , @aaron.ballman > wrote: > >> In D108525#2960765

[PATCH] D108525: Fix documentation and snippets for the handle attributes.

paulherman added a comment. In D108525#2960877 , @aaron.ballman wrote: > In D108525#2960765 , @paulherman > wrote: > >> Thanks for the very prompt review! I'm afraid I no longer have permissions >> to submit --

[PATCH] D108525: Fix documentation and snippets for the handle attributes.

aaron.ballman added a comment. In D108525#2960765 , @paulherman wrote: > Thanks for the very prompt review! I'm afraid I no longer have permissions to > submit --my last commit was in 2015 and I recall that I had SVN access, but > many things have chan

[PATCH] D108525: Fix documentation and snippets for the handle attributes.

paulherman added a comment. Thanks for the very prompt review! I'm afraid I no longer have permissions to submit --my last commit was in 2015 and I recall that I had SVN access, but many things have changed. Would it be possible to submit this on my behalf? Repository: rG LLVM Github Monorep

[PATCH] D108525: Fix documentation and snippets for the handle attributes.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108525/new/ https://reviews.llvm.org/D108525 _

[PATCH] D108525: Fix documentation and snippets for the handle attributes.

paulherman updated this revision to Diff 368127. paulherman added a comment. Explaining the tag argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108525/new/ https://reviews.llvm.org/D108525 Files: clang/include/clang/Basic/AttrDocs.td I

[PATCH] D108525: Fix documentation and snippets for the handle attributes.

aaron.ballman added a comment. Thank you for fixing up the docs! As long as we're here, I suggested some extra documentation wording to make it clear what the argument is and why it's used. Comment at: clang/include/clang/Basic/AttrDocs.td:5884 the function is assumed to fill

[PATCH] D108525: Fix documentation and snippets for the handle attributes.

paulherman created this revision. Herald added a reviewer: aaron.ballman. paulherman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108525 Files: clang/include/clang/Basic