[PATCH] D108493: [HIP] Warn capture this pointer in device lambda

2021-09-08 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG26e492e134c0: [HIP] Warn capture this pointer in device lambda (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Mon

[PATCH] D108493: [HIP] Warn capture this pointer in device lambda

2021-09-08 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaCUDA.cpp:881-882 + } else if (Capture.isThisCapture() && !LangOpts.HIP) { +// Capture of this pointer is allowed for HIP since this pointer

[PATCH] D108493: [HIP] Warn capture this pointer in device lambda

2021-09-08 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Comment at: clang/lib/Sema/SemaCUDA.cpp:881-882 + } else if (Capture.isThisCapture() && !LangOpts.HIP) { +// Capture of this pointer is allowed for HIP since this pointer may be +// pointing to managed memory which is accessible on both device

[PATCH] D108493: [HIP] Warn capture this pointer in device lambda

2021-09-08 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 371363. yaxunl marked an inline comment as done. yaxunl retitled this revision from "[HIP] Allow capture this pointer in device lambda" to "[HIP] Warn capture this pointer in device lambda". yaxunl edited the summary of this revision. CHANGES SINCE LAST ACTION