[PATCH] D108456: [CUDA] Fix static device variables with -fgpu-rdc

This revision was automatically updated to reflect the committed changes. Closed by commit rGea08c4cd1c08: [CUDA] Fix static device variables with -fgpu-rdc (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108456/new/ https://re

[PATCH] D108456: [CUDA] Fix static device variables with -fgpu-rdc

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108456/new/ https://reviews.llvm.org/D108456 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D108456: [CUDA] Fix static device variables with -fgpu-rdc

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Please wait for @yaxunl . I believe he mentioned in D85223 that he'll check whether it works on AMD's end. Comment at: clang/lib/CodeGen/

[PATCH] D108456: [CUDA] Fix static device variables with -fgpu-rdc

Hahnfeld added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6450 llvm::raw_ostream &OS) const { - OS << ".static." << getContext().getCUIDHash(); + OS << "__static__" << getContext().getCUIDHash(); } tra wrote: > I would expect NVPTXA

[PATCH] D108456: [CUDA] Fix static device variables with -fgpu-rdc

tra added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6450 llvm::raw_ostream &OS) const { - OS << ".static." << getContext().getCUIDHash(); + OS << "__static__" << getContext().getCUIDHash(); } I would expect NVPTXAssignValidGlobalNa

[PATCH] D108456: [CUDA] Fix static device variables with -fgpu-rdc

Hahnfeld created this revision. Hahnfeld added reviewers: tra, yaxunl. Hahnfeld requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. NVPTX does not allow dots in the identifier, so ptxas errors out wi