[PATCH] D108380: [openmp][nfc] Refactor GridValues

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2574e63ff71: [openmp][nfc] Refactor GridValues (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108380/new/ https://reviews.llv

[PATCH] D108380: [openmp][nfc] Refactor GridValues

JonChesterfield updated this revision to Diff 368100. JonChesterfield added a comment. - require unsigned shift Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108380/new/ https://reviews.llvm.org/D108380 Files: clang/include/clang/Basic/TargetInf

[PATCH] D108380: [openmp][nfc] Refactor GridValues

JonChesterfield added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:551 + llvm::Log2_32(CGF.getTarget().getGridValue().GV_Warp_Size); + unsigned LaneIDMask = ~0 >> (32u - LaneIDBits); auto &RT = static_cast(CGF.CGM.getOpenMPRuntime()); ---

[PATCH] D108380: [openmp][nfc] Refactor GridValues

JonChesterfield added a comment. Failed a nvptx codegen test (maybe the change to calculate log2 at runtime), currently away from my desk but will revert when I get back unless beaten to it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108380/new/

[PATCH] D108380: [openmp][nfc] Refactor GridValues

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a47a84b4011: [openmp][nfc] Refactor GridValues (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D108380: [openmp][nfc] Refactor GridValues

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108380/new/ https://reviews.llvm.org/D108380 ___

[PATCH] D108380: [openmp][nfc] Refactor GridValues

JonChesterfield updated this revision to Diff 367589. JonChesterfield added a comment. - whitespace, drop asserts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108380/new/ https://reviews.llvm.org/D108380 Files: clang/include/clang/Basic/TargetI

[PATCH] D108380: [openmp][nfc] Refactor GridValues

JonChesterfield updated this revision to Diff 367587. JonChesterfield added a comment. - delete log2 accessors per review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108380/new/ https://reviews.llvm.org/D108380 Files: clang/include/cl

[PATCH] D108380: [openmp][nfc] Refactor GridValues

JonChesterfield added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPGridValues.h:102 +return R; + } }; jdoerfert wrote: > JonChesterfield wrote: > > jdoerfert wrote: > > > It should be in the device rtl then, no? > > This header is curre

[PATCH] D108380: [openmp][nfc] Refactor GridValues

jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPGridValues.h:102 +return R; + } }; JonChesterfield wrote: > jdoerfert wrote: > > It should be in the device rtl then, no? > This header is currently used from clang and the (a

[PATCH] D108380: [openmp][nfc] Refactor GridValues

JonChesterfield added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPGridValues.h:102 +return R; + } }; jdoerfert wrote: > It should be in the device rtl then, no? This header is currently used from clang and the (amdgpu, could also be cu

[PATCH] D108380: [openmp][nfc] Refactor GridValues

jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPGridValues.h:102 +return R; + } }; It should be in the device rtl then, no? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1083

[PATCH] D108380: [openmp][nfc] Refactor GridValues

JonChesterfield updated this revision to Diff 367513. JonChesterfield added a comment. - reorder field Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108380/new/ https://reviews.llvm.org/D108380 Files: clang/include/clang/Basic/TargetInfo.h cla

[PATCH] D108380: [openmp][nfc] Refactor GridValues

JonChesterfield created this revision. JonChesterfield added reviewers: jdoerfert, dpalermo, gregrodgers, ronlieb, tianshilei1992, grokos, atmnpatel. Herald added subscribers: kerbowa, guansong, yaxunl, nhaehnle, jvesely, jholewinski. JonChesterfield requested review of this revision. Herald adde