[PATCH] D108379: [OpenCL] Fix version reporting of C++ for OpenCL 2021

2021-09-21 Thread Justas Janickas via Phabricator via cfe-commits
Topotuna added a comment. Changes rG054e331d9dbd and rG37cdc7ebd9a3 contain test cases that display C++ for OpenCL version 2021 in diagnostics. Reposito

[PATCH] D108379: [OpenCL] Fix version reporting of C++ for OpenCL 2021

2021-08-20 Thread Justas Janickas via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9ae9262857a1: [OpenCL] Fix version reporting of C++ for OpenCL 2021 (authored by Topotuna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108379/new/ https:

[PATCH] D108379: [OpenCL] Fix version reporting of C++ for OpenCL 2021

2021-08-19 Thread Justas Janickas via Phabricator via cfe-commits
Topotuna added a comment. In D108379#2954826 , @Anastasia wrote: > LGTM! Thanks! > > I imagine you will be adding some tests that will check the correctness of > diagnostic wording in the subsequent commits? Yes, I will add tests for diagnostics reporti

[PATCH] D108379: [OpenCL] Fix version reporting of C++ for OpenCL 2021

2021-08-19 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! I imagine you will be adding some tests that will check the correctness of diagnostic wording in the subsequent commits? Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D108379: [OpenCL] Fix version reporting of C++ for OpenCL 2021

2021-08-19 Thread Justas Janickas via Phabricator via cfe-commits
Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, dexonsmith, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. C++ for OpenCL version 2021 and later are expected to consi