[PATCH] D108366: [clang][deps] Deduce resource directory from the compiler path

jansvoboda11 updated this revision to Diff 370851. jansvoboda11 added a comment. Herald added a subscriber: ormris. Rebase on top of D108979 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108366/new/ https://review

[PATCH] D108366: [clang][deps] Deduce resource directory from the compiler path

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. In D108366#2959736 , @jansvoboda11 wrote: > For `clang-scan-deps`, this is //almost// NFC. This code kicks in iff > `ResourceDirect

[PATCH] D108366: [clang][deps] Deduce resource directory from the compiler path

jansvoboda11 added a comment. In D108366#2955322 , @dexonsmith wrote: > The patch seems mostly straightforward, but can you clarify whether there was > a functionality change for clang-scan-deps? My reading of the code suggests > not, because it was us

[PATCH] D108366: [clang][deps] Deduce resource directory from the compiler path

dexonsmith added a comment. The patch seems mostly straightforward, but can you clarify whether there was a functionality change for clang-scan-deps? My reading of the code suggests not, because it was using ResourceDirectoryCache before and still will... in which case, can you walk me through

[PATCH] D108366: [clang][deps] Deduce resource directory from the compiler path

jansvoboda11 updated this revision to Diff 367478. jansvoboda11 added a comment. Account for Windows backslashes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108366/new/ https://reviews.llvm.org/D108366 Files: clang/include/clang/Tooling/Toolin

[PATCH] D108366: [clang][deps] Deduce resource directory from the compiler path

jansvoboda11 added a comment. Tagging @kousikk, since this is related to D69122 that introduced `ResourceDirectoryCache` to `clang-scan-deps`. When the compilation command doesn't have a `-resource-dir` argument, `ResourceDirectoryCache` invokes the specified c

[PATCH] D108366: [clang][deps] Deduce resource directory from the compiler path

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman, kousikk. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After [[libclang][deps] Accept only driver invocations, don't modify t