[PATCH] D108308: Cleanup identifier parsing.

2021-09-14 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the cleanup! I've landed in 601102d282d5e9a1429fea52ee17303aec8a7c10 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D108308: Cleanup identifier parsing.

2021-08-30 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 369446. cor3ntin added a comment. Move a comment to the header file per Aaron request Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108308/new/ https://reviews.llvm.org/D108308 Files: clang-tools-extra/clan

[PATCH] D108308: Cleanup identifier parsing.

2021-08-30 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes LGTM, modulo a commenting request. Let's wait a bit before landing in case @rsmith has concerns. Comment at: clang/include/clang/Lex/Lexer.h:702

[PATCH] D108308: Cleanup identifier parsing.

2021-08-18 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin created this revision. Herald added subscribers: dexonsmith, usaxena95, kadircet, arphaman. Herald added a reviewer: aaron.ballman. cor3ntin requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. - Rename methods to clea