jozefl updated this revision to Diff 392071.
jozefl marked an inline comment as done.
jozefl added a comment.
Thanks, good point, fixed in the attached patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108301/new/
https://reviews.llvm.org/D10830
krisb added inline comments.
Comment at: clang/lib/Driver/ToolChains/MSP430.cpp:223-224
+ MCUData LoadedMCUData;
+ if (const Arg *MCUArg = Args.getLastArg(options::OPT_mmcu_EQ))
+LoadedMCUData = getMCUData(MCUArg->getValue());
+
It might be worth moving thi
jozefl added a comment.
Ping.
Thanks,
Jozef
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108301/new/
https://reviews.llvm.org/D108301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
jozefl added a comment.
Ping.
Thanks,
Jozef
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108301/new/
https://reviews.llvm.org/D108301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
jozefl added a comment.
Ping.
Thanks,
Jozef
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108301/new/
https://reviews.llvm.org/D108301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
jozefl updated this revision to Diff 379011.
jozefl added a comment.
Rebase onto new base revision to fix pre-merge tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108301/new/
https://reviews.llvm.org/D108301
Files:
clang/include/clang/Basi
jozefl added a comment.
Ping.
Thanks,
Jozef
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108301/new/
https://reviews.llvm.org/D108301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lis
jozefl updated this revision to Diff 375666.
jozefl marked 5 inline comments as done.
jozefl added a comment.
Thanks, good points, I have addressed them in this updated patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108301/new/
https://review
asl requested changes to this revision.
asl added a comment.
This revision now requires changes to proceed.
Please see comments inline
Comment at: clang/lib/Driver/ToolChains/MSP430.cpp:43
+/// std::lower_bound is used to perform an efficient binary search on the data.
+static
jozefl updated this revision to Diff 374255.
jozefl added a comment.
Undo incorrect rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108301/new/
https://reviews.llvm.org/D108301
Files:
clang/include/clang/Basic/MSP430Target.def
clang/lib/
jozefl updated this revision to Diff 374200.
jozefl added a comment.
Herald added subscribers: llvm-commits, ormris, hiraditya.
Herald added a project: LLVM.
Rebase to fix patch application failure for
clang/test/Misc/target-invalid-cpu-note.c.
Repository:
rG LLVM Github Monorepo
CHANGES SINC
jozefl added a comment.
Pinging for review.
Thanks,
Jozef
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108301/new/
https://reviews.llvm.org/D108301
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
jozefl added a comment.
Pinging for review.
Thanks,
Jozef
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108301/new/
https://reviews.llvm.org/D108301
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
jozefl updated this revision to Diff 368348.
jozefl added a comment.
Here's an updated patch that fixes some minor nits.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108301/new/
https://reviews.llvm.org/D108301
Files:
clang/include/clang/Basic/
jozefl updated this revision to Diff 367805.
jozefl added a comment.
Here's an updated patch to fix the win64 failure.
MSVC can't handle the conversion from a ForwardIterator to a const pointer when
the container being searched with std::lower_bound is a std::array. Meanwhile
clang-tidy warns whe
jozefl updated this revision to Diff 367739.
jozefl added a comment.
Here's an updated patch that stores the HWMult and CPU data for each MCU as
strings instead of enums. This simplifies the patch as string conversions to
and from enums are no longer required.
Repository:
rG LLVM Github Monore
jozefl added a comment.
Now that I am in the process of implementing the processing of the "CPU"
feature, I've realized the decision to store the CPU and HWMult information as
enums instead of strings has some downsides that may outweigh the benefits:
- All string values passed to options need to
jozefl updated this revision to Diff 367458.
jozefl added a comment.
Fixed clang-tidy warnings.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108301/new/
https://reviews.llvm.org/D108301
Files:
clang/include/clang/Basic/MSP430Target.def
clang/
jozefl created this revision.
jozefl added a reviewer: asl.
jozefl requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch updates MSP430 MCU data to the latest version distributed by
TI, adding support for 451 additional MCUs.
The hard
19 matches
Mail list logo
