[PATCH] D108211: Emit sizeof/alignof values as notes when a static_assert fails

arichardson abandoned this revision. arichardson added a comment. Would require significant work to still be useful now that we print the value of expressions (e.g. only print for more complex expressions). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D108211: Emit sizeof/alignof values as notes when a static_assert fails

aaron.ballman added a comment. In D108211#3748595 , @tbaeder wrote: > From looking at the output in the test cases, the additional diagnostics > seem unnecessary to me in almost all cases...? +1; my observation is that the extra note repeats informati

[PATCH] D108211: Emit sizeof/alignof values as notes when a static_assert fails

tbaeder added a comment. From looking at the output in the test cases, the additional diagnostics seem unnecessary to me in almost all cases...? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108211/new/ https://reviews.llvm.org/D108211

[PATCH] D108211: Emit sizeof/alignof values as notes when a static_assert fails

arichardson added a reviewer: tbaeder. arichardson added a comment. This is less useful now that 09117b21890c652994f7ada0229d309b35b44259 / D130894 has landed, but it might still be worth in

[PATCH] D108211: Emit sizeof/alignof values as notes when a static_assert fails

arichardson updated this revision to Diff 455258. arichardson marked 2 inline comments as done. arichardson added a comment. Herald added a project: All. rebase and address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108211/new/ https://

[PATCH] D108211: Emit sizeof/alignof values as notes when a static_assert fails

aaron.ballman added a reviewer: rsmith. aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:3598 return true; +} else if (auto *UE = dyn_cast(E)) { + Expr::EvalResult Result; Comment at: clang/test/

[PATCH] D108211: Emit sizeof/alignof values as notes when a static_assert fails

arichardson created this revision. arichardson added reviewers: courbet, Quuxplusone, aaron.ballman. arichardson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Trying to debug a static_assert(sizeof(foo) == ...) failure can be rather awkwa