[PATCH] D108173: [WIP][clang] Add a cmake flag for choosing to build clang-repl

phosek added a comment. Rather than hardcoding this only for `clang-repl`, I'd prefer to use a more generic approach. We already have `LLVM_DISTRIBUTION_COMPONENTS` so one possibility would be to set a lit feature for every component. For example, if `LLVM_DISTRIBUTION_COMPONENTS=foo;bar` we w

[PATCH] D108173: [WIP][clang] Add a cmake flag for choosing to build clang-repl

tstellar added a comment. > Not all downstream users may want to build all tools shipped with clang. > clang-repl for us in particular can sometimes lead to flaky builds when > testing a toolchain built with LTO. Can we just fix clang-repl instead? I think there needs to be a more compelling

[PATCH] D108173: [WIP][clang] Add a cmake flag for choosing to build clang-repl

leonardchan planned changes to this revision. leonardchan added inline comments. Comment at: clang/CMakeLists.txt:468 +option(CLANG_BUILD_CLANG_REPL_DEFAULT "Build clang-repl by default." OFF) + Apart from name bikeshedding, it's more likely we'll want this `ON

[PATCH] D108173: [WIP][clang] Add a cmake flag for choosing to build clang-repl

leonardchan created this revision. leonardchan added a project: clang. Herald added a subscriber: mgorny. leonardchan requested review of this revision. Not all downstream users may want to build all tools shipped with clang. `clang-repl` for us in particular can sometimes lead to flaky builds wh