lebedev.ri added a comment.
:(
I'm sorry for derailing this.
I still think proper switch handling for loops would be nice.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108138/new/
https://reviews.llvm.org/D108138
___
cfe-commits mailing list
kmclaughlin abandoned this revision.
kmclaughlin added a comment.
I just wanted to give an update on this patch, which I'm abandoning for the
time being:
@lebedev.ri raised some good questions about the approach taken and whether the
additional compile time spent would be worth the additional o
lebedev.ri added a comment.
Hi. I'm personally still not very okay with the approach as it currently is.
Do you need to run LoopRotate after lowering switches? Anything else?
But then you don't actually know that after spending all this compile time,
the vectorization will actually happen, and y
kmclaughlin added a comment.
Hi all, I've updated this to take a different approach - the new patch runs
LowerSwitch just before the vectoriser, where it will only consider simple
switches which are part of a loop. For these switches, the pass will create a
series of branches and compares which
kmclaughlin updated this revision to Diff 372706.
kmclaughlin retitled this revision from "[SimplifyCFG] Remove switch statements
before vectorization" to "[WIP] Remove switch statements before vectorization".
kmclaughlin edited the summary of this revision.
kmclaughlin added a comment.
Herald add
