[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

2021-08-31 Thread Yaron Keren via Phabricator via cfe-commits
yaron.keren marked an inline comment as done. yaron.keren added inline comments. Comment at: clang/test/utils/update_cc_test_checks/lit.local.cfg:24 +# Windows: llvm-lit.py, Linux: llvm-lit +llvm_lit = glob.glob(os.path.join(config.llvm_tools_dir, 'llvm-lit*'))[0] +lit = config.l

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

2021-08-30 Thread Tom Stellard via Phabricator via cfe-commits
tstellar added inline comments. Comment at: clang/test/utils/update_cc_test_checks/lit.local.cfg:24 +# Windows: llvm-lit.py, Linux: llvm-lit +llvm_lit = glob.glob(os.path.join(config.llvm_tools_dir, 'llvm-lit*'))[0] +lit = config.llvm_external_lit if config.llvm_external_lit else

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

2021-08-17 Thread Yaron Keren via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5aa0f9cc9ab2: Use installed llvm-lit.py instead of lit.py PR-51072 (authored by yaron.keren). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108085/new/ http

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

2021-08-17 Thread Douglas Yung via Phabricator via cfe-commits
dyung accepted this revision. dyung added a comment. This revision is now accepted and ready to land. LGTM and I can confirm that this change fixes the check-globals.test that was failing due to this issue. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

2021-08-17 Thread Yaron Keren via Phabricator via cfe-commits
yaron.keren updated this revision to Diff 366941. yaron.keren added a comment. Switched to Linux repo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108085/new/ https://reviews.llvm.org/D108085 Files: clang/test/utils/update_cc_test_checks/lit.lo

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

2021-08-15 Thread Yaron Keren via Phabricator via cfe-commits
yaron.keren updated this revision to Diff 366515. yaron.keren added a comment. Support both Windows llvm-lit.py and Linux llvm-lit command name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108085/new/ https://reviews.llvm.org/D108085 Files: cla

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

2021-08-15 Thread Yaron Keren via Phabricator via cfe-commits
yaron.keren added a comment. looking into Linux failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108085/new/ https://reviews.llvm.org/D108085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

2021-08-15 Thread Yaron Keren via Phabricator via cfe-commits
yaron.keren created this revision. yaron.keren added reviewers: Orlando, probinson, tstellar. yaron.keren requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Three tests fail when building and testing LLVM from the Visual C++ environment since