Re: [PATCH] D10807: clang-format: Add SpaceAfterTemplate

2016-08-09 Thread Sylvestre Ledru via cfe-commits
sylvestre.ledru added a comment. Done in https://reviews.llvm.org/D23317 https://reviews.llvm.org/D10807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10807: clang-format: Add SpaceAfterTemplate

2016-08-09 Thread Michael Rybakov via cfe-commits
opilarium added a comment. > Thanks. I am rebasing and updating the patch. Waiting for you. https://reviews.llvm.org/D10807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10807: clang-format: Add SpaceAfterTemplate

2016-08-09 Thread Sylvestre Ledru via cfe-commits
sylvestre.ledru added a comment. Thanks. I am rebasing and updating the patch. I don't know if poiru is still around. https://reviews.llvm.org/D10807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D10807: clang-format: Add SpaceAfterTemplate

2016-08-09 Thread Daniel Jasper via cfe-commits
djasper added a comment. I still believe it's wrong to care about this in particular, but I also don't want to hold clang-format hostage for my own beliefs. Obviously, enough people care and the costs are limited. Comment at: include/clang/Format/Format.h:356 @@ +355,3 @@ + /

Re: [PATCH] D10807: clang-format: Add SpaceAfterTemplate

2016-08-09 Thread Michael Rybakov via cfe-commits
opilarium added a comment. Can we just accept this merge request? It's backward compatible and helps Mozilla to adapt clang-format. https://reviews.llvm.org/D10807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

Re: [PATCH] D10807: clang-format: Add SpaceAfterTemplate

2016-08-09 Thread Michael Rybakov via cfe-commits
opilarium added a comment. It's the huge deal for my company too. It would be nice if you reconsider. https://reviews.llvm.org/D10807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10807: clang-format: Add SpaceAfterTemplate

2016-08-09 Thread Sylvestre Ledru via cfe-commits
sylvestre.ledru added a comment. To be clear, this is blocking Mozilla to use much more clang-format https://reviews.llvm.org/D10807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits