[PATCH] D107971: [openmp] Annotate tmp variables with omp_thread_mem_alloc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdbd7bad9ad9b: [openmp] Annotate tmp variables with omp_thread_mem_alloc (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D107971: [openmp] Annotate tmp variables with omp_thread_mem_alloc

JonChesterfield updated this revision to Diff 367374. JonChesterfield added a comment. - add minimal omp.h to clang test inputs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107971/new/ https://reviews.llvm.org/D107971 Files: clang/lib/Headers/_

[PATCH] D107971: [openmp] Annotate tmp variables with omp_thread_mem_alloc

JonChesterfield added a comment. intended content for the new omp.h is #ifndef __OMP_H #define __OMP_H #if _OPENMP // Follows the pattern in interface.h // Clang sema checks this type carefully, needs to closely match that from omp.h typedef enum omp_allocator_handle_t { omp_n

[PATCH] D107971: [openmp] Annotate tmp variables with omp_thread_mem_alloc

jdoerfert added a comment. In D107971#2941739 , @JonChesterfield wrote: > Failed a CI job that builds an openmp test in an environment without omp.h, > will revert. > > Thoughts on fixing? Putting the omp allocator definition in this header is > likely

[PATCH] D107971: [openmp] Annotate tmp variables with omp_thread_mem_alloc

JonChesterfield added a comment. Failed a CI job that builds an openmp test in an environment without omp.h, will revert. Thoughts on fixing? Putting the omp allocator definition in this header is likely to collide with a real omp.h. Fairly clean fix is to move the definitions into the deviceR

[PATCH] D107971: [openmp] Annotate tmp variables with omp_thread_mem_alloc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6113548c921: [openmp] Annotate tmp variables with omp_thread_mem_alloc (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D107971: [openmp] Annotate tmp variables with omp_thread_mem_alloc

JonChesterfield added a comment. In D107971#2941666 , @jdoerfert wrote: > Assuming this causes us to generate an `alloc as(5)` for `__tmp`, LG Yes, with the running example and this patch we get the perfect: %__tmp = alloca double, align 8, addrspace(

[PATCH] D107971: [openmp] Annotate tmp variables with omp_thread_mem_alloc

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Assuming this causes us to generate an `alloc as(5)` for `__tmp`, LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107971/new/ https://rev

[PATCH] D107971: [openmp] Annotate tmp variables with omp_thread_mem_alloc

JonChesterfield added reviewers: ye-luo, yaxunl. JonChesterfield added a subscriber: ye-luo. JonChesterfield added a comment. @ye-luo this fixes the modf and sincos test cases from https://github.com/ye-luo/openmp-target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D107971: [openmp] Annotate tmp variables with omp_thread_mem_alloc

JonChesterfield created this revision. JonChesterfield added reviewers: arsenm, jdoerfert. Herald added subscribers: guansong, yaxunl. JonChesterfield requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, wdng. Herald added a project: clang. Fixes miscompile of calls