[PATCH] D107952: [AMDGPU][OpenMP] Use llvm-link to link ocml libraries

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG60e07a956862: [AMDGPU][OpenMP] Use llvm-link to link ocml libraries (authored by Pushpinder Singh ). Repository: r

[PATCH] D107952: [AMDGPU][OpenMP] Use llvm-link to link ocml libraries

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. LG, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107952/new/ https://reviews.llvm.org/D107952 __

[PATCH] D107952: [AMDGPU][OpenMP] Use llvm-link to link ocml libraries

pdhaliwal added inline comments. Comment at: clang/test/Driver/amdgpu-openmp-toolchain.c:80 +// CHECK-LIB-DEVICE: {{.*}}llvm-link{{.*}}ocml.bc"{{.*}}ockl.bc"{{.*}}oclc_daz_opt_on.bc"{{.*}}oclc_unsafe_math_off.bc"{{.*}}oclc_finite_only_off.bc"{{.*}}oclc_correctly_rounded_sqrt_on.

[PATCH] D107952: [AMDGPU][OpenMP] Use llvm-link to link ocml libraries

pdhaliwal updated this revision to Diff 365965. pdhaliwal added a comment. Remove redundant test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107952/new/ https://reviews.llvm.org/D107952 Files: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp cla

[PATCH] D107952: [AMDGPU][OpenMP] Use llvm-link to link ocml libraries

JonChesterfield added a comment. This is semantically different to using mlink-builtin-bitcode with clang. The former internalizes all the symbols after they are introduced, using llvm-link does not. I'm not immediately sure whether that is a problem - the symbols in rocm device libs should all

[PATCH] D107952: [AMDGPU][OpenMP] Use llvm-link to link ocml libraries

pdhaliwal created this revision. pdhaliwal added reviewers: ronlieb, JonChesterfield. Herald added subscribers: kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. pdhaliwal requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, wdng. Herald