This revision was automatically updated to reflect the committed changes.
Closed by commit rG1bd4dc4f2854: [hmaptool] Port to python3 (authored by lanza).
Changed prior to commit:
https://reviews.llvm.org/D107944?vs=388568&id=388668#toc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107944/new/
https://reviews.llvm.org/D107944
___
cfe-commits mailing list
cfe-commits@li
lanza updated this revision to Diff 388568.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107944/new/
https://reviews.llvm.org/D107944
Files:
clang/utils/hmaptool/hmaptool
Index: clang/utils/hmaptool/hmaptool
===
--- cla
ivanmurashko added inline comments.
Comment at: clang/utils/hmaptool/hmaptool:223
with open(output_path, 'wb') as f:
f.write(magic.encode())
f.write(struct.pack(header_fmt, *header))
`magic` is a bytes object that does not have `encode()` m
bruno added a comment.
Overall looks great but there are some test failures, looks like you also need
to update line 223?
--
Traceback (most recent call last):
File "/var/lib/buildkite-agent/builds/llvm-project/build/bin/hmaptool",
line 296, in
main()
File "/var/lib/buildkite
lanza created this revision.
lanza requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This is just a few trivial changes -- change the interpreter and fix a
few byte-vs-string issues.
Repository:
rG LLVM Github Monorepo
https://reviews.ll
