This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG70b06fe8a186: scan-build-py: Force the opening in utf-8
(authored by sylvestre.ledru).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACT
sylvestre.ledru updated this revision to Diff 366937.
sylvestre.ledru added a comment.
Replace " => '
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107887/new/
https://reviews.llvm.org/D107887
Files:
clang/tools/scan-build-py/lib/libscanbuild/re
phosek accepted this revision.
phosek added a comment.
LGTM
Comment at: clang/tools/scan-build-py/lib/libscanbuild/report.py:420
-with open(filename) as handler:
+with open(filename, encoding="utf-8") as handler:
for line in handler.readlines():
-
isthismyaccount accepted this revision.
isthismyaccount added a comment.
This revision is now accepted and ready to land.
Seems reasonable to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107887/new/
https://reviews.llvm.org/D107887
__
sylvestre.ledru created this revision.
sylvestre.ledru added reviewers: phosek, isthismyaccount, aabbaabb.
Herald added a subscriber: whisperity.
sylvestre.ledru requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
It fails on ubuntu bionic othe
