david-arm added a comment.
Hi, this has broken the build for me too.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107764/new/
https://reviews.llvm.org/D107764
___
cfe-commits mailing list
cfe-commits@li
lkail added a comment.
This looks has broken build if `-DBUILD_SHARED_LIBS=On` is specified.
CMake Error: The inter-target dependency graph contains the following
strongly connected component (cycle):
"LLVMFrontendOpenMP" of type SHARED_LIBRARY
depends on "LLVMPasses" (weak)
"LLV
kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
LGTM. Thanks for the responses.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107764/new/
https://reviews.llvm.org/D107764
___
Meinersbur added inline comments.
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:2055
+/// Attach loop metadata \p Properties to the loop described by \p Loop. If the
+/// loop already has metadata, the loop properties are appended.
+static void addLoopMetadata(CanonicalLo
kiranchandramohan added a comment.
I have a few minor questions.
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:2055
+/// Attach loop metadata \p Properties to the loop described by \p Loop. If the
+/// loop already has metadata, the loop properties are appended.
+static
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LG, minor comments below.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2639-2643
+if (UnrolledCLI) {
+ OMPLoopNestStack.push_back(UnrolledCLI);
+} else {
