[PATCH] D107760: [clang] Fix warning -Wnon-virtual-dtor.

2021-08-09 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added inline comments. Comment at: clang/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp:311 : OpenCLBuiltinFileEmitterBase(Records, OS) {} + virtual ~OpenCLBuiltinTestEmitter() = default; Tip: When you're putting a defaulted virtual destructor

[PATCH] D107760: [clang] Fix warning -Wnon-virtual-dtor.

2021-08-09 Thread Adrian Kuegel via Phabricator via cfe-commits
akuegel added a comment. Already landed as https://github.com/llvm/llvm-project/commit/19bd806a1a443e4ce45ccc670861848fb1579022, I will close this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107760/new/ https://reviews.llvm.org/D107760 __

[PATCH] D107760: [clang] Fix warning -Wnon-virtual-dtor.

2021-08-09 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107760/new/ https://reviews.llvm.org/D107760 ___