[PATCH] D107720: [analyzer] Cleanup a FIXME in SValBuilder.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rGd39ebdae674c: [analyzer] Cleanup a FIXME in SValBuilder.cpp (authored by vabridgers, committed by einvbri ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D107720: [analyzer] Cleanup a FIXME in SValBuilder.cpp

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Awesome, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107720/new/ https://reviews.llvm.org/D107720 _

[PATCH] D107720: [analyzer] Cleanup a FIXME in SValBuilder.cpp

vabridgers updated this revision to Diff 365582. vabridgers added a comment. only need the one test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107720/new/ https://reviews.llvm.org/D107720 Files: clang/lib/StaticAnalyzer/Core/SValBuilder.

[PATCH] D107720: [analyzer] Cleanup a FIXME in SValBuilder.cpp

vabridgers updated this revision to Diff 365546. vabridgers added a comment. add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107720/new/ https://reviews.llvm.org/D107720 Files: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp clang/te

[PATCH] D107720: [analyzer] Cleanup a FIXME in SValBuilder.cpp

vabridgers updated this revision to Diff 365310. vabridgers added a comment. Add missing test case :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107720/new/ https://reviews.llvm.org/D107720 Files: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp

[PATCH] D107720: [analyzer] Cleanup a FIXME in SValBuilder.cpp

vabridgers added a comment. I'll add a test and repost. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107720/new/ https://reviews.llvm.org/D107720 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D107720: [analyzer] Cleanup a FIXME in SValBuilder.cpp

NoQ added a comment. Looks correct. Tests pls? I think that's one of the places where `clang_analyzer_dump()` is appropriate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107720/new/ https://reviews.llvm.org/D107720

[PATCH] D107720: [analyzer] Cleanup a FIXME in SValBuilder.cpp

vabridgers created this revision. vabridgers added reviewers: NoQ, vsavchenko, ASDenysPetrov, steakhal, martong. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. vabridgers requested review of