[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGece4e9208521: [CodeComplete] Basic code completion for attribute names. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

aaron.ballman added a comment. In D107696#2939827 , @aaron.ballman wrote: > Btw, I'm not certain why patch application is failing for you in the > precommit CI: > https://buildkite.com/llvm-project/diff-checks/builds/58571#c186a7d3-f5c9-4ad2-ae27-07408

[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Btw, I'm not certain why patch application is failing for you in the precommit CI: https://buildkite.com/llvm-project/diff-checks/builds/58571#c186a7d3-f5c9-4ad2-ae27-07408b1c5da

[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

sammccall added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4390 + auto AddCompletions = [&](const ParsedAttrInfo &A) { +if (A.IsTargetSpecific && !A.existsInTarget(Context.getTargetInfo())) + return; aaron.ballman wrote: > Should w

[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4390 + auto AddCompletions = [&](const ParsedAttrInfo &A) { +if (A.IsTargetSpecific && !A.existsInTarget(Context.getTargetInfo())) + return; Should we also early return

[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

sammccall updated this revision to Diff 365490. sammccall added a comment. Herald added subscribers: sstefan1, krytarowski. Herald added a reviewer: jdoerfert. Add support and tests for underscore-guarding. Add tests that omp attributes are not supported. Repository: rG LLVM Github Monorepo C

[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

aaron.ballman added a comment. In D107696#2934881 , @sammccall wrote: > Thanks, I know what to do next! > > While I have you here, any thoughts on future patches: > >> Only the bare name is completed, with no args. >> For args to be useful we need arg nam

[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

sammccall planned changes to this revision. sammccall added a comment. Thanks, I know what to do next! While I have you here, any thoughts on future patches: > Only the bare name is completed, with no args. > For args to be useful we need arg names. These *are* in the tablegen but > not currentl

[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4357 +continue; + llvm::StringRef Name = S.NormalizedFullName; + if (Completion == AttributeCompletion::Scope) { sammccall wrote: > aaron.ballman wrote: > > Sho

[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

sammccall added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4357 +continue; + llvm::StringRef Name = S.NormalizedFullName; + if (Completion == AttributeCompletion::Scope) { aaron.ballman wrote: > Should we also add some spec

[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

aaron.ballman added a comment. Thank you for working on this, I think it's fantastic functionality! Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4357 +continue; + llvm::StringRef Name = S.NormalizedFullName; + if (Completion == AttributeCompletion::Scope) {

[PATCH] D107696: [CodeComplete] Basic code completion for attribute names.

sammccall created this revision. sammccall added reviewers: aaron.ballman, kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Only the bare name is completed,