[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

benshi001 added a comment. In D107672#2932442 , @mhjacobson wrote: > In D107672#2932413 , @mhjacobson > wrote: > >> At first glance, I think you're right: avr-gcc does expect avr-libc to be >> relative to itsel

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

mhjacobson added a comment. In D107672#2932423 , @MaskRay wrote: > @benshi001 This was prematurely committed. It has no test and has apparent > unaddressed issue. (I revamped many parts in the Linux/Gnu search paths so > am quite confident about my obs

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

mhjacobson added a comment. In D107672#2932413 , @mhjacobson wrote: > At first glance, I think you're right: avr-gcc does expect avr-libc to be > relative to itself. That seems slightly weird to me (since avr-libc is > technically separate from GCC),

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

MaskRay added a comment. @benshi001 This was prematurely committed. It has no test and has apparent unaddressed issue. (I revamped many parts in the Linux/Gnu search paths so quite confident about my observation.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

mhjacobson added a comment. In D107672#2932406 , @MaskRay wrote: > I know nearly nothing about AVR, but from `avr-gcc a.c '-###'` I doubt this > is the GCC behavior. GCC's library path is relative to the GCC installation. > `/usr/lib/gcc/avr/5.4.0/../..

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71e71067f3fa: [AVR][clang] Add '$SYSROOT/avr' to possible avr-libc locations (authored by mhjacobson, committed by benshi001). Repository: rG LLVM

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

MaskRay added a comment. I know nearly nothing about AVR, but from `avr-gcc a.c '-###'` I doubt this is the GCC behavior. GCC's library path is relative to the GCC installation. `/usr/lib/gcc/avr/5.4.0/../../../avr/lib` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

mhjacobson added a comment. In D107672#2932190 , @mhjacobson wrote: > I'm also tempted to remove `/usr/lib/avr`, because these paths make no sense > to me: `$SYSROOT/usr/lib/avr/lib` and `$SYSROOT/usr/lib/avr/include`. Ah. According to https://reviews

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

mhjacobson added a comment. I'm also tempted to remove `/usr/lib/avr`, because these paths make no sense to me: `$SYSROOT/usr/lib/avr/lib` and `$SYSROOT/usr/lib/avr/include`. But I haven't done that here, in case there's some reason those paths do make sense. (Also, the files in `clang/test/Dr

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

mhjacobson created this revision. mhjacobson added reviewers: benshi001, MaskRay, dylanmckay. Herald added a subscriber: Jim. mhjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The paths in PossibleAVRLibcLocations are appended with