kadircet added inline comments.
Comment at: clang-tools-extra/clangd/CompileCommands.cpp:250
+ ArgList.getLastArgNoClaim(driver::options::OPT__DASH_DASH)) {
+for (auto I = 0U; I <= DashDash->getNumValues(); ++I)
+ IndicesToDrop.push_back(DashDash->getIndex() + I
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG79c2616d315f: [clangd] Canonicalize inputs provided with
`--` (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTI
kadircet updated this revision to Diff 364764.
kadircet marked an inline comment as done.
kadircet added a comment.
- Cmd.resize instead of dropping arguments trailing `--` one by one.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107637/new/
https
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/CompileCommands.cpp:250
+ ArgList.getLastArgNoClaim(driver::options::OPT__DASH_DASH)) {
+for (auto I = 0U; I <= Da
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: usaxena95, arphaman.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
We already strip all the inputs
