This revision was automatically updated to reflect the committed changes.
Closed by commit rG8008009fd25b: [OpenCL] Initialize temporaries in the private
address space (authored by olestrohm).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107553/new/
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107553/new/
https://reviews.llvm.org/D107553
___
cfe-commits mailing list
olestrohm updated this revision to Diff 367455.
olestrohm added a comment.
I made the check into an assert as suggested.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107553/new/
https://reviews.llvm.org/D107553
Files:
clang/include/clang/Sema/Initialization.h
clang/lib/Sema/SemaEx
Anastasia added inline comments.
Comment at: clang/include/clang/Sema/Initialization.h:341
+QualType Type = TypeInfo->getType();
+if (Context.getLangOpts().OpenCL && !Type.hasAddressSpace())
+ Type = Context.getAddrSpaceQualType(Type, LangAS::opencl_private);
---
olestrohm created this revision.
olestrohm added reviewers: Anastasia, rjmccall.
olestrohm added a project: clang.
Herald added subscribers: ldrumm, yaxunl.
olestrohm requested review of this revision.
Herald added a subscriber: cfe-commits.
This patch fixes initializing temporaries, which are cur
