This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa614a28772cb: [PowerPC] Do not define __PRIVILEGED__
(authored by stefanp).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https
NeHuang accepted this revision as: NeHuang.
NeHuang added a comment.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107461/new/
https://reviews.llvm.org/D107461
___
cfe-commits mailing list
cfe-commi
stefanp updated this revision to Diff 365278.
stefanp added a comment.
Revewiers had a good catch where I forgot to add an equals sign to check
in the test case. I've fixed that test now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107461/new/
ht
NeHuang added inline comments.
Comment at: clang/test/Driver/ppc-mprivileged-support-check.c:25
+// HASPRIV: test() #0 {
+// HASPRIV: attributes #0 {
+// HASPRIV-SAME: +privileged
maybe check for `attributes #0 = {`
Repository:
rG LLVM Github Monorepo
CHAN
jsji added a comment.
> x64 debian > Clang.Driver::ppc-mprivileged-support-check.c
The changed test is failing ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107461/new/
https://reviews.llvm.org/D107461
__
stefanp created this revision.
stefanp added reviewers: nemanjai, lei.
Herald added subscribers: shchenz, kbarton.
stefanp requested review of this revision.
Herald added a project: clang.
We do not want to define __PRIVILEGED__. There is no use case for the
definition and gcc does not define it.
