[PATCH] D107402: Correct a lot of diagnostic wordings for the driver

aaron.ballman closed this revision. aaron.ballman added a comment. This was committed in 530ea28fefc4652823a187a149e8001cbf4af18f . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107402/new/ https://reviews.llvm.org/D1

[PATCH] D107402: Correct a lot of diagnostic wordings for the driver

aaron.ballman updated this revision to Diff 364212. aaron.ballman added a comment. Updating for some test cases that are still failing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107402/new/ https://reviews.llvm.org/D107402 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D107402: Correct a lot of diagnostic wordings for the driver

aaron.ballman updated this revision to Diff 364172. aaron.ballman added a comment. Updating based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107402/new/ https://reviews.llvm.org/D107402 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Drive

[PATCH] D107402: Correct a lot of diagnostic wordings for the driver

erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:88 +def err_drv_bad_target_id : Error< + "invalid target ID: %0 (a target ID is a processor name followed by an " + "optional list of predefined features post-fixed by a plus or min

[PATCH] D107402: Correct a lot of diagnostic wordings for the driver

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:88 +def err_drv_bad_target_id : Error< + "invalid target ID: %0 (a target ID is a processor name followed by an " + "optional list of predefined features post-fixed by a plus or mi

[PATCH] D107402: Correct a lot of diagnostic wordings for the driver

aaron.ballman updated this revision to Diff 364134. aaron.ballman added a comment. More testing fixes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107402/new/ https://reviews.llvm.org/D107402 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/Cud

[PATCH] D107402: Correct a lot of diagnostic wordings for the driver

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. The changes in this patch are all fine to me! I'm a little disturbed that it only broke 1 test though... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107402/new/ https://rev

[PATCH] D107402: Correct a lot of diagnostic wordings for the driver

aaron.ballman added a comment. In D107402#2925402 , @erichkeane wrote: > The changes in this patch are all fine to me! I'm a little disturbed that it > only broke 1 test though... Thanks for the review! The test coverage for driver diagnostics definit

[PATCH] D107402: Correct a lot of diagnostic wordings for the driver

aaron.ballman updated this revision to Diff 364093. aaron.ballman marked 5 inline comments as done. aaron.ballman added a comment. Updating based on review feedback and restarting the CI pipeline. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107402/new/ https://reviews.llvm.org/D107402

[PATCH] D107402: Correct a lot of diagnostic wordings for the driver

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:88 +def err_drv_bad_target_id : Error< + "invalid target ID: %0 (a target ID is a processor name followed by an " + "optional list of predefined features post-fixed by a plus or

[PATCH] D107402: Correct a lot of diagnostic wordings for the driver

erichkeane added a comment. Just some thoughts! See what you like/don't like here, i'm not attached to my suggestions. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:86 +def err_drv_mix_cuda_hip : Error< + "mixed CUDA and HIP compilation is not supported">; +

[PATCH] D107402: Correct a lot of diagnostic wordings for the driver

aaron.ballman updated this revision to Diff 364065. aaron.ballman added a comment. Herald added subscribers: kerbowa, nhaehnle, jvesely, emaste. Fixing the tests I couldn't test locally but were found by the CI pipeline. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107402/new/ https://

[PATCH] D107402: Correct a lot of diagnostic wordings for the driver

aaron.ballman created this revision. aaron.ballman added a reviewer: erichkeane. Herald added subscribers: phosek, jfb. aaron.ballman requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Herald added a project: clang. Clang diagnostics should