[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9dabacd09fdd: [analyzer] Adjust JS code of analyzer's HTML report for IE support. (authored by ASDenysPetrov). Changed prior to commit: https://reviews.llvm.org/D107366?vs=364418&id=366923#toc Reposito

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Now it looks good! Thanks again! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107366/new/ https://reviews.llvm.org/D107366 ___ c

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

ASDenysPetrov added a comment. Is it ready to load now? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107366/new/ https://reviews.llvm.org/D107366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

ASDenysPetrov added a comment. F18367476: report-86a04f.html - Final sample file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107366/new/ https://reviews.llvm.org/D107366 ___ cfe-commits mailing list cf

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

ASDenysPetrov updated this revision to Diff 364418. ASDenysPetrov added a comment. Final fixes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107366/new/ https://reviews.llvm.org/D107366 Files: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp Index: clang/lib/StaticAnalyzer/Core/H

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

ASDenysPetrov added a comment. In D107366#2927842 , @vsavchenko wrote: > Now it captures (and makes bold) one extra arrow from the previous note. > Correct example attached! > F18364580: report-e4b488.html Damn. I've

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:1373 + var array = []; + for (var i = lower; i <= upper; ++i) { + array.push(i); ASDenysPetrov wrote: > NoQ wrote: > > Shouldn't it be `i < upper`? > `[lower, u

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

vsavchenko added a comment. Now it captures (and makes bold) one extra arrow from the previous note. Correct example attached! F18364580: report-e4b488.html CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107366/new/ https://reviews.llvm.org/D107366 _

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

vsavchenko requested changes to this revision. vsavchenko added a comment. This revision now requires changes to proceed. Oh, wait! I found a bug! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107366/new/ https://reviews.llvm.org/D107366 ___

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

vsavchenko accepted this revision. vsavchenko added a comment. In D107366#2926662 , @ASDenysPetrov wrote: > In D107366#2926343 , @NoQ wrote: > >> Works in Firefox on macOS as well! > > Great! > @vsavchenko , any

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

ASDenysPetrov added a comment. In D107366#2926343 , @NoQ wrote: > Works in Firefox on macOS as well! Great! @vsavchenko , any suggestions? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107366/new/ https://reviews.llvm.org/D107366

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Works in Firefox on macOS as well! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107366/new/ https://reviews.llvm.org/D107366 ___ cfe-commits ma

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

ASDenysPetrov added a comment. F18343863: report-cdf7f5.html This is a sample file which now should work both on IE and Chromium-based browsers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107366/new/ https://reviews.llvm.org/D107366

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

ASDenysPetrov updated this revision to Diff 364078. ASDenysPetrov added a comment. Replaced a closure in `highlightArrowsForSelectedEvent ` with function object. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107366/new/ https://reviews.llvm.org/D107366 Files: clang/lib/StaticAnalyzer

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

ASDenysPetrov updated this revision to Diff 364068. ASDenysPetrov added a comment. Corrected nits. Thanks to "the sharp eye" @vsavchenko =). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107366/new/ https://reviews.llvm.org/D107366 Files: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

vsavchenko added a comment. Can you please also attach an HTML file just to verify that it works? Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:1293 +var classListAdd = function(el, theClass) { + if(!el.className.baseVal) +el.className += " " + theClass; --

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

ASDenysPetrov updated this revision to Diff 364030. ASDenysPetrov added a comment. Fixed the range in `range` function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107366/new/ https://reviews.llvm.org/D107366 Files: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp Index: clang/

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:1352-1356 + // key 'j' + if (event.keyCode == 74) { navigateTo(/*up=*/false); - } else if (event.key == "k") { + // key 'k' + } else if (event.keyCode == 75) { ---

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:1352-1356 + // key 'j' + if (event.keyCode == 74) { navigateTo(/*up=*/false); - } else if (event.key == "k") { + // key 'k' + } else if (event.keyCode == 75) { This

[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: vsavchenko, NoQ. ASDenysPetrov added a project: clang. Herald added subscribers: manas, steakhal, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. ASDenysPetrov requested r