[PATCH] D107349: [Matrix] Overload stride arg in matrix.columnwise.load/store.

fhahn added a comment. In D107349#2941385 , @erichkeane wrote: > In D107349#2941257 , @mehdi_amini > wrote: > >> Revert to unbreak bots (like this one : >> https://lab.llvm.org/buildbot/#/builders/13/builds/109

[PATCH] D107349: [Matrix] Overload stride arg in matrix.columnwise.load/store.

erichkeane added a comment. In D107349#2941257 , @mehdi_amini wrote: > Revert to unbreak bots (like this one : > https://lab.llvm.org/buildbot/#/builders/13/builds/10930 ) Looks like this should be a pretty trivial test update at least. Repository:

[PATCH] D107349: [Matrix] Overload stride arg in matrix.columnwise.load/store.

mehdi_amini added a comment. Revert to unbreak bots (like this one : https://lab.llvm.org/buildbot/#/builders/13/builds/10930 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107349/new/ https://reviews.llvm.org/D107349 ___

[PATCH] D107349: [Matrix] Overload stride arg in matrix.columnwise.load/store.

akuegel added a comment. It seems this patch caused a test failure in MLIR: test/Target/LLVMIR/llvm-intrinsics.mlir Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107349/new/ https://reviews.llvm.org/D107349

[PATCH] D107349: [Matrix] Overload stride arg in matrix.columnwise.load/store.

fhahn added a comment. In D107349#2922208 , @erichkeane wrote: > This looks fine to me, and seems to fix my problem, thanks! I didn't spot > anything obvious,and proof-read the LangRef and think it is all fine, but am > not really the expert here, so

[PATCH] D107349: [Matrix] Overload stride arg in matrix.columnwise.load/store.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1ef81de35a4: [Matrix] Overload stride arg in matrix.columnwise.load/store. (authored by fhahn). Changed prior to commit: https://reviews.llvm.org

[PATCH] D107349: [Matrix] Overload stride arg in matrix.columnwise.load/store.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This looks fine to me, and seems to fix my problem, thanks! I didn't spot anything obvious,and proof-read the LangRef and think it is all fine, but am not really the expert here, so p

[PATCH] D107349: [Matrix] Overload stride arg in matrix.columnwise.load/store.

fhahn created this revision. fhahn added reviewers: rjmccall, anemet, thegameg, erichkeane. Herald added subscribers: dexonsmith, jdoerfert, tschuett, hiraditya. fhahn requested review of this revision. Herald added projects: clang, LLVM. This patch adjusts the intrinsics definition of llvm.matrix