This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG14cb67862a72: [OpenCL] allow generic address and non-generic
defs for CL3.0 (authored by airlied).
Repository:
rG LLVM Github Monorepo
CHANGES SI
airlied added a comment.
@azabaznov no bad effects here in my initial basic testing with CL 3.0, I'll
land this tomorrow or next day when I get a chance.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107318/new/
https://reviews.llvm.org/D107318
_
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107318/new/
https://reviews.llvm.org/D107318
_
azabaznov added a comment.
Yeah, this looks good. Thanks! Please notify when this is ready to land.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107318/new/
https://reviews.llvm.org/D107318
___
cfe-comm
airlied added a subscriber: azabaznov.
airlied added a comment.
@azabaznov is this what you meant? I haven't tested this yet as my clang dev
box died, but I'll get to it as soon as I can.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107318/new/
h
airlied created this revision.
airlied added a project: clang.
Herald added subscribers: ldrumm, Anastasia, yaxunl.
airlied requested review of this revision.
Herald added a subscriber: cfe-commits.
This allows both sets of definitions to exist on CL 3.0
Repository:
rG LLVM Github Monorepo
ht
