This revision was automatically updated to reflect the committed changes.
Closed by commit rGf6bc614546e1: [clan-format] detect function definitions more
conservatively (authored by krasimir).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107269/new/
owenpan accepted this revision.
owenpan added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107269/new/
https://reviews.llvm.org/D107269
_
krasimir added inline comments.
Comment at: clang/lib/Format/TokenAnnotator.cpp:2485-2486
if (Next->Next && Next->Next->is(tok::identifier) &&
- !(Next->MatchingParen->Next && Next->MatchingParen->Next->is(tok::semi)))
+ (!Next->MatchingParen->Next ||
+ Next->M
krasimir updated this revision to Diff 363669.
krasimir added a comment.
- apply review suggestion
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107269/new/
https://reviews.llvm.org/D107269
Files:
clang/lib/Format/TokenAnnotator.cpp
clang/unit
owenpan added inline comments.
Comment at: clang/lib/Format/TokenAnnotator.cpp:2485-2486
if (Next->Next && Next->Next->is(tok::identifier) &&
- !(Next->MatchingParen->Next && Next->MatchingParen->Next->is(tok::semi)))
+ (!Next->MatchingParen->Next ||
+ Next->Ma
krasimir created this revision.
krasimir requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
https://reviews.llvm.org/D105964 updated the detection of function
definitions. It had the unfortunate effect to start marking object
definitions with
