[PATCH] D107244: [AIX] Define _ARCH_PPC64 macro for 32-bit

This revision was automatically updated to reflect the committed changes. Closed by commit rG41bcfe81742e: [AIX] Define _ARCH_PPC64 macro for 32-bit (authored by Jake-Egan). Changed prior to commit: https://reviews.llvm.org/D107244?vs=364766&id=364793#toc Repository: rG LLVM Github Monorepo

[PATCH] D107244: [AIX] Define _ARCH_PPC64 macro for 32-bit

cebowleratibm accepted this revision. cebowleratibm added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107244/new/ https://reviews.llvm.org/D107244

[PATCH] D107244: [AIX] Define _ARCH_PPC64 macro for 32-bit

Jake-Egan updated this revision to Diff 364766. Jake-Egan added a comment. Updated the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107244/new/ https://reviews.llvm.org/D107244 Files: clang/lib/Basic/Targets/PPC.cpp clang/test/Prepro

[PATCH] D107244: [AIX] Define _ARCH_PPC64 macro for 32-bit

cebowleratibm requested changes to this revision. cebowleratibm added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Basic/Targets/PPC.cpp:260 + } else if (getTriple().isOSAIX()) { +// Also define _ARCH_PPC64 for 32-bit on AIX. +Bui

[PATCH] D107244: [AIX] Define _ARCH_PPC64 macro for 32-bit

Jake-Egan updated this revision to Diff 364342. Jake-Egan added a comment. Merge else and if. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107244/new/ https://reviews.llvm.org/D107244 Files: clang/lib/Basic/Targets/PPC.cpp clang/test/Preproce

[PATCH] D107244: [AIX] Define _ARCH_PPC64 macro for 32-bit

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:259 Builder.defineMacro("__PPC64__"); + // Also define _ARCH_PPC64 for 32-bit on AIX. + } else { Merge `else` with single `if`-statement as the sole contents of the b

[PATCH] D107244: [AIX] Define _ARCH_PPC64 macro for 32-bit

Jake-Egan updated this revision to Diff 364330. Jake-Egan added a comment. Add comment. clang-format suggests a second indent, but I think this is correct because the comment is addressing the else clause. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D107244: [AIX] Define _ARCH_PPC64 macro for 32-bit

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:260 + } else { +if (getTriple().isOSAIX()) + Builder.defineMacro("_ARCH_PPC64"); cebowleratibm wrote: > A comment is warranted here to explain that __ARCH_PPC64 is

[PATCH] D107244: [AIX] Define _ARCH_PPC64 macro for 32-bit

cebowleratibm requested changes to this revision. cebowleratibm added a comment. This revision now requires changes to proceed. The divergence with GCC is regrettable. Unfortunately defining _ARCH_PPC64 in 32-bit has been a long-standing discrepancy between xlc and gcc and one I don't expect gc