[PATCH] D107231: [clang-repl] Fix building with win32 dylibs

2021-08-02 Thread Tom Stellard via Phabricator via cfe-commits
tstellar added a comment. @mstorsjo Yes, go ahead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107231/new/ https://reviews.llvm.org/D107231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D107231: [clang-repl] Fix building with win32 dylibs

2021-08-01 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a subscriber: tstellar. mstorsjo added a comment. In D107231#2918835 , @v.g.vassilev wrote: > In D107231#2918834 , @mstorsjo > wrote: > >> In D107231#2918824

[PATCH] D107231: [clang-repl] Fix building with win32 dylibs

2021-08-01 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added a comment. In D107231#2918834 , @mstorsjo wrote: > In D107231#2918824 , @v.g.vassilev > wrote: > >> Forgot to mention that we may need to backport this patch to the llvm13 >> branch. > > That

[PATCH] D107231: [clang-repl] Fix building with win32 dylibs

2021-08-01 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In D107231#2918824 , @v.g.vassilev wrote: > Forgot to mention that we may need to backport this patch to the llvm13 > branch. That might be good yes, especially if you intend to enable it by default there too. (I only noticed

[PATCH] D107231: [clang-repl] Fix building with win32 dylibs

2021-08-01 Thread Martin Storsjö via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG25a288b009f7: [clang-repl] Fix building with win32 dylibs (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107231/new/ https://reviews.

[PATCH] D107231: [clang-repl] Fix building with win32 dylibs

2021-08-01 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added a comment. Forgot to mention that we may need to backport this patch to the llvm13 branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107231/new/ https://reviews.llvm.org/D107231 __

[PATCH] D107231: [clang-repl] Fix building with win32 dylibs

2021-08-01 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107231/new/ https://reviews.llvm.org/D107231

[PATCH] D107231: [clang-repl] Fix building with win32 dylibs

2021-07-31 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo created this revision. mstorsjo added reviewers: v.g.vassilev, teemperor. Herald added a subscriber: mgorny. mstorsjo requested review of this revision. Herald added a project: clang. Use `clang_target_link_libraries` to avoid duplicate libraries when the same symbol is provided both by a