This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9d4faa8ac3e7: [PowerPC] Implement cmplxl builtins (authored
by Conanap).
Changed prior to commit:
https://reviews.llvm.org/D107138?vs=365596&id=36
NeHuang accepted this revision.
NeHuang added a comment.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107138/new/
https://reviews.llvm.org/D107138
___
cfe-commits mailing list
cfe-commits@lists.llv
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107138/new/
https://reviews.llvm.org/D107138
__
Conanap updated this revision to Diff 365596.
Conanap added a comment.
Removed unintended change
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107138/new/
https://reviews.llvm.org/D107138
Files:
clang/lib/Basic/Targets/PPC.cpp
clang/test/CodeG
Conanap updated this revision to Diff 365289.
Conanap marked 3 inline comments as done.
Conanap added a comment.
Merged the test case into the existing cmplx test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107138/new/
https://reviews.llvm.org/D1
nemanjai added inline comments.
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-complex.c:1
+// RUN: %clang_cc1 -O2 -triple powerpc64-unknown-unknown \
+// RUN: -emit-llvm %s -o - -target-cpu pwr7 | FileCheck %s
Conanap wrote:
> NeHuang wrote:
> > NeHuang
NeHuang added inline comments.
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-complex.c:45
+ // CHECK-AIX-NEXT: ret { double, double } %.fca.1.insert
+ return __cmplxl(lda, ldb);
+}
nemanjai wrote:
> We really only need this test case and we should be abl
Conanap marked an inline comment as done.
Conanap added inline comments.
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-complex.c:1
+// RUN: %clang_cc1 -O2 -triple powerpc64-unknown-unknown \
+// RUN: -emit-llvm %s -o - -target-cpu pwr7 | FileCheck %s
NeH
Conanap updated this revision to Diff 364223.
Conanap marked 6 inline comments as done.
Conanap added a comment.
Removed backend tests, removed some uneeded definitions,
updated frontend test with regex for variable names.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https:
amyk added inline comments.
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-complex.c:35
+ // CHECK-NEXT: %1 = load ppc_fp128, ppc_fp128* @ldb
+ // CHECK-NEXT: %.fca.0.insert = insertvalue { ppc_fp128, ppc_fp128 } undef,
ppc_fp128 %0, 0
+ // CHECK-NEXT: %.fca.1.insert =
NeHuang added inline comments.
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-complex.c:1
+// RUN: %clang_cc1 -O2 -triple powerpc64-unknown-unknown \
+// RUN: -emit-llvm %s -o - -target-cpu pwr7 | FileCheck %s
`// REQUIRES: powerpc-registered-target`
==
nemanjai requested changes to this revision.
nemanjai added inline comments.
This revision now requires changes to proceed.
Comment at: clang/include/clang/Basic/BuiltinsPPC.def:146
BUILTIN(__builtin_ppc_stfiw, "viC*d", "")
+BUILTIN(__builtin_ppc_cmplxl, "XLdLdLd", "")
---
Conanap created this revision.
Herald added subscribers: shchenz, kbarton, nemanjai.
Conanap requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
This patch implements the builtins for cmplxl by utilising
__builtin_complex. Thi
13 matches
Mail list logo
