This revision was automatically updated to reflect the committed changes.
Closed by commit rGf9c8602b53fd: clangd: Provide hover info for include
directives (authored by ckandeler, committed by sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org
sammccall added a comment.
All done! Sorry for the delay.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107137/new/
https://reviews.llvm.org/D107137
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
ckandeler added a comment.
Thanks for the review. Can you please merge it? I don't have the permissions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107137/new/
https://reviews.llvm.org/D107137
___
cfe
ckandeler updated this revision to Diff 363442.
ckandeler added a comment.
Addressed lint comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107137/new/
https://reviews.llvm.org/D107137
Files:
clang-tools-extra/clangd/Hover.cpp
clang-tools
ckandeler updated this revision to Diff 363083.
ckandeler added a comment.
Addressed comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107137/new/
https://reviews.llvm.org/D107137
Files:
clang-tools-extra/clangd/Hover.cpp
clang-tools-ext
sammccall added a comment.
Thanks, this is great! I think we need to hold the line a bit on keeping
different hovers uniform though.
Comment at: clang-tools-extra/clangd/Hover.cpp:914
+ HoverInfo HI;
+ HI.TargetFile = File->Definition;
+ return HI;
-
ckandeler created this revision.
ckandeler added a reviewer: sammccall.
Herald added subscribers: usaxena95, kadircet, arphaman.
ckandeler requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
It's quite useful
