This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe0f2d4af031c: [clangd] Fix the crash in getQualification
(authored by kbobyrev).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107047/new/
https://reviews.llvm.org/D107047
__
kbobyrev updated this revision to Diff 363383.
kbobyrev added a comment.
Add test, improve docs in code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107047/new/
https://reviews.llvm.org/D107047
Files:
clang-tools-extra/clangd/AST.cpp
clang-t
kbobyrev updated this revision to Diff 362707.
kbobyrev added a comment.
Make the controol flow less confusing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107047/new/
https://reviews.llvm.org/D107047
Files:
clang-tools-extra/clangd/AST.cpp
kadircet added a comment.
thanks for chasing this down! as mentioned offline a test case like:
namespace ns {
extern "C" {
typedef int foo;
}
foo Fo^o(int id) { return id; }
}
in define outline should be enough to ensure it is WAI.
Comment at: clang-tools-extra/cl
kbobyrev updated this revision to Diff 362687.
kbobyrev added a comment.
Fix formatting
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107047/new/
https://reviews.llvm.org/D107047
Files:
clang-tools-extra/clangd/AST.cpp
Index: clang-tools-extra
kbobyrev created this revision.
kbobyrev added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman.
kbobyrev requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Happens when DestContext is Link
