This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7a797b290299: Take OptimizationLevel class out of Pass
Builder (authored by tarinduj, committed by mtrofin).
Repository:
rG LLVM Github Monorepo
tarinduj updated this revision to Diff 362962.
tarinduj added a comment.
added newline at the end to OptimizationLevel.h
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107025/new/
https://reviews.llvm.org/D107025
Files:
clang/lib/CodeGen/BackendUtil.cpp
llvm/examples/Bye/Bye.cpp
l
mtrofin accepted this revision.
mtrofin added inline comments.
This revision is now accepted and ready to land.
Comment at: llvm/include/llvm/Passes/OptimizationLevel.h:128
+#endif
\ No newline at end of file
add a newline here (it helps diff tools)
CHANGES SI
tarinduj updated this revision to Diff 362692.
tarinduj added a comment.
clang-format
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107025/new/
https://reviews.llvm.org/D107025
Files:
clang/lib/CodeGen/BackendUtil.cpp
llvm/examples/Bye/Bye.cpp
llvm/include/llvm/Passes/Optimizatio
tarinduj updated this revision to Diff 362675.
tarinduj added a comment.
added namespace and header guards
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107025/new/
https://reviews.llvm.org/D107025
Files:
clang/lib/CodeGen/BackendUtil.cpp
llvm
mtrofin added inline comments.
Comment at: llvm/include/llvm/Passes/OptimizationLevel.h:14
+//===--===//
+
+class OptimizationLevel final {
this should be in the llvm namespace
tarinduj created this revision.
tarinduj added reviewers: jdoerfert, mtrofin, uenoku.
tarinduj added a project: LLVM.
Herald added subscribers: ormris, foad, kerbowa, steven_wu, hiraditya,
nhaehnle, jvesely, arsenm, jholewinski.
Herald added a reviewer: bollu.
tarinduj requested review of this rev
