[PATCH] D107004: Turn off fp reassociation in IA intrinsic header files.

2021-08-02 Thread Kevin B. Smith via Phabricator via cfe-commits
kbsmith1 abandoned this revision. kbsmith1 added a comment. Doesn't seem to have community support, abandoning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107004/new/ https://reviews.llvm.org/D107004

[PATCH] D107004: Turn off fp reassociation in IA intrinsic header files.

2021-07-29 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon requested changes to this revision. RKSimon added a comment. This revision now requires changes to proceed. I really don't support this change - -ffast-math should be allowed to perform aggressive folds and it makes no sense to make an exception for common intrinsics like these. We shou

[PATCH] D107004: Turn off fp reassociation in IA intrinsic header files.

2021-07-28 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: clang/lib/Headers/emmintrin.h:13 +/* Turn off reassociation for inrinsics, push state to restore at end. */ +#pragma float_control(push) inrinsics->intrinsics Comment at: clang/lib/Headers/xmmin

[PATCH] D107004: Turn off fp reassociation in IA intrinsic header files.

2021-07-28 Thread Kevin B. Smith via Phabricator via cfe-commits
kbsmith1 added a comment. In D107004#2911654 , @lebedev.ri wrote: > Patch description states what the change is, but not why the change is what > it is. > I don't think this is a good direction to second-guess the user's intentions. I added the reason

[PATCH] D107004: Turn off fp reassociation in IA intrinsic header files.

2021-07-28 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. Patch description states what the change is, but not why the change is what it is. I don't think this is a good direction to second-guess the user's intentions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107004/new/

[PATCH] D107004: Turn off fp reassociation in IA intrinsic header files.

2021-07-28 Thread Kevin B. Smith via Phabricator via cfe-commits
kbsmith1 created this revision. kbsmith1 added reviewers: craig.topper, aaron.ballman, erichkeane, andrew.w.kaylor. kbsmith1 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change uses #pragma float_control and floating point fast-mat