[PATCH] D106939: [RISCV] If the maskedoff is vundefined(), use ta, ma for vsetvli.

frasercrmck added a comment. In D106939#2915784 , @HsiangKai wrote: > In D106939#2915134 , @HsiangKai > wrote: > >> In D106939#2912807 , @frasercrmck >> wrote: >> >>> LG

[PATCH] D106939: [RISCV] If the maskedoff is vundefined(), use ta, ma for vsetvli.

HsiangKai added a comment. In D106939#2915134 , @HsiangKai wrote: > In D106939#2912807 , @frasercrmck > wrote: > >> LGTM but there are test failures. Is that just a whole load of `mu->ma` >> changes that have be

[PATCH] D106939: [RISCV] If the maskedoff is vundefined(), use ta, ma for vsetvli.

HsiangKai added a comment. In D106939#2912807 , @frasercrmck wrote: > LGTM but there are test failures. Is that just a whole load of `mu->ma` > changes that have been omitted for a smaller diff? Updated test cases are put in https://reviews.llvm.org/D1

[PATCH] D106939: [RISCV] If the maskedoff is vundefined(), use ta, ma for vsetvli.

HsiangKai updated this revision to Diff 362920. HsiangKai added a comment. - Add more comments. - Remove unnecessary `--riscv-no-aliases` in the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106939/new/ https://reviews.llvm.org/D106939

[PATCH] D106939: [RISCV] If the maskedoff is vundefined(), use ta, ma for vsetvli.

craig.topper added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/maskedoff-undef.ll:3 +; RUN: llc -mtriple=riscv64 -mattr=+experimental-v -verify-machineinstrs \ +; RUN: --riscv-no-aliases < %s | FileCheck %s + frasercrmck wrote: > I don't think we'r

[PATCH] D106939: [RISCV] If the maskedoff is vundefined(), use ta, ma for vsetvli.

frasercrmck added a comment. LGTM but there are test failures. Is that just a whole load of `mu->ma` changes that have been omitted for a smaller diff? Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:379 bool ForceTailAgnostic = RISCVII::doesForceTailAgnostic(TSFla

[PATCH] D106939: [RISCV] If the maskedoff is vundefined(), use ta, ma for vsetvli.

HsiangKai updated this revision to Diff 362617. HsiangKai added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106939/new/ https://reviews.llvm.org/D106939 Files: clang/test/CodeGen/RISCV/rvv-intrinsics/maskedoff-unde

[PATCH] D106939: [RISCV] If the maskedoff is vundefined(), use ta, ma for vsetvli.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:379 bool ForceTailAgnostic = RISCVII::doesForceTailAgnostic(TSFlags); + // hasDummyMaskOp(TSFlags) == ture means it is a non-masked instruction. + // FIXME: hasDummyMaskOp() is the c

[PATCH] D106939: [RISCV] If the maskedoff is vundefined(), use ta, ma for vsetvli.

HsiangKai created this revision. HsiangKai added reviewers: frasercrmck, khchen, arcbbb, rogfer01, evandro, craig.topper. Herald added subscribers: StephenFan, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones,