This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG47d9d55c6660: [clangd] Do not show inlay hints pertaining to
code in other files (authored by nridge).
Repository:
rG LLVM Github Monorepo
CHANGE
nridge updated this revision to Diff 366552.
nridge added a comment.
Address review comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106934/new/
https://reviews.llvm.org/D106934
Files:
clang-tools-extra/clangd/InlayHints.cpp
clang-tools-e
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/InlayHints.cpp:320
+// file that was included after the preamble), do not show in that case.
+if (AST.getSourceManager().getFileID(FileRange->getBegin()) != MainFileID)
+ return;
k
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/InlayHints.cpp:320
+// file that was included after the preamble), do not show in that case.
+if (AST.getSourceManager().getFileID(FileRange->getBegin()) != MainFileID)
+ return;
sa
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/InlayHints.cpp:320
+// file that was included after the preamble), do not show in that case.
+if (AST.getSourceManager(
nridge created this revision.
nridge added a reviewer: sammccall.
Herald added subscribers: usaxena95, kadircet, arphaman.
nridge requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Fixes https://github.com/cl
