This revision was automatically updated to reflect the committed changes.
Closed by commit rG0556138624ed: [clang][cli] Expose -fno-cxx-modules in cc1
(authored by jansvoboda11).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106864/new/
https://revi
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106864/new/
https://reviews.llvm.org/D106864
___
cfe-commits mailing list
c
jansvoboda11 added inline comments.
Comment at: clang/test/Modules/cxx20-disable.cpp:2
+// RUN: rm -rf %t && mkdir %t
+// RUN: not %clang_cc1 -x objective-c++ -std=c++20 -fno-cxx-modules -I %t %s
+
arphaman wrote:
> jansvoboda11 wrote:
> > I'm not sure how to bes
jansvoboda11 updated this revision to Diff 363071.
jansvoboda11 added a comment.
Add negative test, check error messages.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106864/new/
https://reviews.llvm.org/D106864
Files:
clang/include/clang/Driver/Options.td
clang/lib/Frontend/Compi
arphaman added inline comments.
Comment at: clang/test/Modules/cxx20-disable.cpp:2
+// RUN: rm -rf %t && mkdir %t
+// RUN: not %clang_cc1 -x objective-c++ -std=c++20 -fno-cxx-modules -I %t %s
+
jansvoboda11 wrote:
> I'm not sure how to best test this. Checking th
jansvoboda11 added inline comments.
Comment at: clang/test/Modules/cxx20-disable.cpp:2
+// RUN: rm -rf %t && mkdir %t
+// RUN: not %clang_cc1 -x objective-c++ -std=c++20 -fno-cxx-modules -I %t %s
+
I'm not sure how to best test this. Checking the error messages i
jansvoboda11 created this revision.
jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman.
Herald added a subscriber: dang.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
For some use-cases, it might be useful to be ab
