[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

saiislam added a comment. In D106809#2994169 , @dyung wrote: > In D106809#2994067 , @saiislam > wrote: > >> In D106809#2993666 , @kwk wrote: >> >>> @saiislam please have

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

dyung added a comment. In D106809#2994067 , @saiislam wrote: > In D106809#2993666 , @kwk wrote: > >> @saiislam please have a look into why this happens. Is the >> `-debug-only=CodeObjectCompatibility` maybe a lef

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

saiislam added a comment. In D106809#2993666 , @kwk wrote: > @saiislam please have a look into why this happens. Is the > `-debug-only=CodeObjectCompatibility` maybe a left-over of some sort? No, it is not a left-over. I was using this debug output to s

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

kwk added a comment. @saiislam please have a look into why this happens. Is the `-debug-only=CodeObjectCompatibility` maybe a left-over of some sort? Comment at: clang/test/Driver/clang-offload-bundler.c:405 +// Tests to check compatibility between Bundle Entry ID formats i.e.

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

RKSimon added inline comments. Comment at: clang/test/Driver/clang-offload-bundler.c:405 +// Tests to check compatibility between Bundle Entry ID formats i.e. between presence/absence of extra hyphen in case of missing environment field +// RUN: clang-offload-bundler -unbundle -

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

This revision was automatically updated to reflect the committed changes. Closed by commit rG98380762c3b7: [clang-offload-bundler] Make Bundle Entry ID backward compatible (authored by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106809/n

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

grokos accepted this revision. grokos added a comment. LGTM as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106809/new/ https://reviews.llvm.org/D106809 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. Ideally, we probably need something like isValidOffloadArch(Triple, OffloadArch) or getTargetTriple(OffloadArch). However, I think the current patch is good enough for its own purpose. Repos

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

saiislam updated this revision to Diff 371133. saiislam marked 2 inline comments as done. saiislam added a comment. 1. Added tests for empty and incompatible archives. 2. Improved identification of GPUArch in Bundle Entry ID using CudaArch. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

yaxunl added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:148 +// Check if the last option before any colon is a triple field or a GPU name +if (TripleOrGPU.second.startswith("gfx") || +TripleOrGPU.second.startswith("sm_"

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

saiislam updated this revision to Diff 370219. saiislam added a comment. Added test cases for compatibility old and new formats of bundle entry id. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106809/new/ https://reviews.llvm.org/D106809 Files:

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

grokos added a comment. LG. One possible suggestion is that you leave the double dash (`--`) variant in some tests so that we can make sure both variants (e.g. both `openmp-amdgcn-amd-amdhsa--gfx906` and `openmp-amdgcn-amd-amdhsa-gfx906`) are correctly parsed. Repository: rG LLVM Github Mon

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

saiislam added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106809/new/ https://reviews.llvm.org/D106809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

saiislam created this revision. saiislam added reviewers: jdoerfert, yaxunl, grokos. saiislam requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Earlier BundleEntryID used to be --. This used to work because the clang-offload-bundler