[PATCH] D106804: [test-suite] Add tests for FP classification intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rTb983131b7e46: [test-suite] Add tests for FP classification intrinsics (authored by sepavloff). Repository: rT test-suite CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106804/new/ https://revie

[PATCH] D106804: [test-suite] Add tests for FP classification intrinsics

sepavloff added a comment. Thanks! Repository: rT test-suite CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106804/new/ https://reviews.llvm.org/D106804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D106804: [test-suite] Add tests for FP classification intrinsics

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rT test-suite CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106804/new/ https://reviews.llvm.org/D106804 ___ cfe-com

[PATCH] D106804: [test-suite] Add tests for FP classification intrinsics

sepavloff added a comment. If nobody objects, I would commit this change, as it would be useful in the forthcoming return of `llvm.isnan`. Repository: rT test-suite CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106804/new/ https://reviews.llvm.org/D106804 __

[PATCH] D106804: [test-suite] Add tests for FP classification intrinsics

sepavloff added a comment. In D106804#2991411 , @RKSimon wrote: > Do we have test-suite buildbot coverage on anything other than x86? Cross > platform uses of long double is always fun The following build bots have a stage named `test-suite`: c

[PATCH] D106804: [test-suite] Add tests for FP classification intrinsics

RKSimon added a comment. I've no objections to this - it seems to be orthogonal to the isnan ir intrinsic conversation. Do we have test-suite buildbot coverage on anything other than x86? Cross platform uses of long double is always fun Any other comments? Repository: rT test-suite

[PATCH] D106804: [test-suite] Add tests for FP classification intrinsics

sepavloff added a comment. In D106804#2956881 , @RKSimon wrote: > Something I noticed is that we don't have much test coverage in > clang/test/codegen for the fpclass intrinsics - including no constexpr > testing afaict (although I don't think __builtin

[PATCH] D106804: [test-suite] Add tests for FP classification intrinsics

sepavloff updated this revision to Diff 368687. sepavloff added a comment. Updated patch - Moved tests into header files. It should facilitate writing tests for various modes (strict exceptions, fast math etc), - Added Makefile, - Enhanced diagnostics if test fails, - Avoid C++, it makes easier

[PATCH] D106804: [test-suite] Add tests for FP classification intrinsics

RKSimon added a comment. Something I noticed is that we don't have much test coverage in clang/test/codegen for the fpclass intrinsics - including no constexpr testing afaict (although I don't think __builtin_fpclassify is constexpr yet) - is that something you'd be willing to take a look at?

[PATCH] D106804: [test-suite] Add tests for FP classification intrinsics

sepavloff created this revision. sepavloff added reviewers: efriedma, kpn, thopre, jonpa, cameron.mcinally, RKSimon, craig.topper. Herald added a subscriber: mgorny. sepavloff requested review of this revision. Repository: rT test-suite https://reviews.llvm.org/D106804 Files: SingleSource/U