[PATCH] D106789: [clang][Driver] Expose driver mode detection logic

kadircet added a comment. Argh, sorry for the mess, sent out D109361 . FYI, before this patch clang preferred the last `--driver-mode` in case of multiple ones and started preferring the first one with this patch. In https://github.com/llvm/llvm-project/blob/ma

[PATCH] D106789: [clang][Driver] Expose driver mode detection logic

hans added a comment. Somehow this seems to have broken the `--driver-mode=` flag when passed to clang-cl. The flag is supposed to override the mode inferred from the filename, but it's not working anymore. For example: Before: $ bin/clang-cl --driver-mode=gcc -target x86_64 -c /tmp/a.c -###

[PATCH] D106789: [clang][Driver] Expose driver mode detection logic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. kadircet marked 3 inline comments as done. Closed by commit rGce90b60bd09d: [clang][Driver] Expose driver mode detection logic (authored by kadircet). Herald added a re

[PATCH] D106789: [clang][Driver] Expose driver mode detection logic

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Driver/Driver.h:643 +/// Returns the driver mode option's value, i.e. `X` in `--driver-mode=X`. If \p +/// Args doesn't mention o

[PATCH] D106789: [clang][Driver] Expose driver mode detection logic

kadircet updated this revision to Diff 361656. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106789/new/ https://reviews.llvm.org/D106789 Files: clang/include/clang/Driver/Driver.h clang/lib/Driver/Driver.cpp

[PATCH] D106789: [clang][Driver] Expose driver mode detection logic

kadircet updated this revision to Diff 361646. kadircet added a comment. - Preserve no diagnostic behaviour in case of an empty driver. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106789/new/ https://reviews.llvm.org/D106789 Files: clang/inclu

[PATCH] D106789: [clang][Driver] Expose driver mode detection logic

kadircet created this revision. kadircet added a reviewer: sammccall. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also use it in other places that performed it on their own. Repository: rG LLVM Github Monorepo https://revi