[PATCH] D106715: Thread safety analysis: Drop special block handling

2021-09-20 Thread Aaron Puchert via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6de19ea4b626: Thread safety analysis: Drop special block handling (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D106715: Thread safety analysis: Drop special block handling

2021-09-20 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Marking this explicitly as accepted, I'd say you're fine to land and we can handle any concerns from @delesley post commit. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D106715: Thread safety analysis: Drop special block handling

2021-09-18 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106715/new/ https://reviews.llvm.org/D106715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D106715: Thread safety analysis: Drop special block handling

2021-07-26 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert updated this revision to Diff 361820. aaronpuchert marked 2 inline comments as done. aaronpuchert added a comment. Drop `SpecialBlocks` and fix clang-tidy issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106715/new/ https://reviews

[PATCH] D106715: Thread safety analysis: Drop special block handling

2021-07-26 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. I think this looks reasonable, but @delesley should weigh in. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2415 bool LocksetInitialized = false; SmallVector SpecialBlocks; for (CFGBlock::const_pred_iterator PI = CurrBlock->pred_b

[PATCH] D106715: Thread safety analysis: Drop special block handling

2021-07-23 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, delesley. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previous changes like D101202 and D104261