[PATCH] D106645: [clangd] Tweak constructor of dex AndIterator for performance.

2021-08-02 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev requested changes to this revision. kbobyrev added a comment. This revision now requires changes to proceed. As discussed offline, does not yield performance improvements. Putting on "Request Changes" so that I don't miss ongoing reviews (please let me know if that's OK with you). Rep

[PATCH] D106645: [clangd] Tweak constructor of dex AndIterator for performance.

2021-07-23 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev added a comment. I am extremely confused, but this is actually 4.5% slower than the updated (improved performance with D106528 ) baseline. Now, this actually works (2.2-2.5% faster): ❯ git diff diff --git a/clang-tools-extra/clangd/index/dex/Iterat

[PATCH] D106645: [clangd] Tweak constructor of dex AndIterator for performance.

2021-07-23 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Calling sync() *aft