This revision was automatically updated to reflect the committed changes.
Closed by commit rGa0987e350ccc: [clangd] Improve performance of dex by 45-60%
(authored by kbobyrev).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106528/new/
https://review
kbobyrev updated this revision to Diff 360970.
kbobyrev added a comment.
Add more comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106528/new/
https://reviews.llvm.org/D106528
Files:
clang-tools-extra/clangd/index/dex/Iterator.cpp
Index
kbobyrev updated this revision to Diff 360968.
kbobyrev added a comment.
Add another 7% compared to the patched version: cache Child->peek() in the
loop.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106528/new/
https://reviews.llvm.org/D106528
Fi
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Iterator.cpp:91
/// sync.
void sync() {
ReachedEnd |= Children.front()->reachedEnd();
sammccall wrote:
> I stared at this for a while and this change makes me think about th
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Nice find!
Comment at: clang-tools-extra/clangd/index/dex/Iterator.cpp:91
/// sync.
void sync() {
ReachedEnd |= Children.front()->reachedEnd();
-
kbobyrev created this revision.
kbobyrev added a reviewer: sammccall.
Herald added subscribers: usaxena95, arphaman.
kbobyrev requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Take full advantage of AND's it
