This revision was automatically updated to reflect the committed changes.
Closed by commit rG7cc8a8e3849d: [clangd] Canonicalize compile flags before
applying edits (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106527/new/
ht
kadircet updated this revision to Diff 361183.
kadircet marked 2 inline comments as done.
kadircet added a comment.
Change occurence of ArgList usage for canonical prefixes to `Has`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106527/new/
https://
sammccall accepted this revision.
sammccall added a comment.
Still LG
Comment at: clang-tools-extra/clangd/CompileCommands.cpp:250
auto It = llvm::find(Cmd, "--");
for (std::string &Arg : ToAppend)
Cmd.insert(It++, std::move(Arg));
hmm, why isn
kadircet marked 6 inline comments as done.
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/CompileCommands.cpp:210
+ if (!ArgList.hasArgNoClaim(driver::options::OPT__DASH_DASH)) {
+// In theory there might be more than one input, but clangd can't deal wi
kadircet updated this revision to Diff 361133.
kadircet marked 3 inline comments as done.
kadircet added a comment.
- Address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106527/new/
https://reviews.llvm.org/D106527
Files:
clang
kadircet updated this revision to Diff 360835.
kadircet added a comment.
- Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106527/new/
https://reviews.llvm.org/D106527
Files:
clang-tools-extra/clangd/CompileCommands.cpp
clang-tools-extra/
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/CompileCommands.cpp:210
+ if (!ArgList.hasArgNoClaim(driver::options::OPT__DASH_DASH)) {
+// In theory there might be more than one input, but clangd can't deal with
+// them anyway.
s
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/CompileCommands.cpp:210
+ if (!ArgList.hasArgNoClaim(driver::options::OPT__DASH_DASH)) {
+// In theory there might be more
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: usaxena95, arphaman.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Pushes input for the compile ac
