[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

erichkeane added inline comments. Comment at: clang/www/cxx_status.html:1106 https://wg21.link/p1073r3";>P1073R3 - No + Partial cor3ntin wrote: > erichkeane wrote: > > I'm trying to evaluate our consteval support, and I am having trouble >

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin added inline comments. Comment at: clang/www/cxx_status.html:1106 https://wg21.link/p1073r3";>P1073R3 - No + Partial erichkeane wrote: > I'm trying to evaluate our consteval support, and I am having trouble finding > any unsuperce

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

erichkeane added inline comments. Comment at: clang/www/cxx_status.html:1106 https://wg21.link/p1073r3";>P1073R3 - No + Partial I'm trying to evaluate our consteval support, and I am having trouble finding any unsuperceded part of P1073R3

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

aaron.ballman closed this revision. aaron.ballman added a comment. I have commit on your behalf in 131b4620ee7847102479f399ce3e35a3c1cb5461 , thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106302/new/ https://reviews.llvm.org/D106302

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin updated this revision to Diff 364778. cor3ntin added a comment. Changing release version to clang 14 in cxx_status Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106302/new/ https://reviews.llvm.org/D106302 Files: clang/lib/Sema/SemaExpr

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin updated this revision to Diff 364765. cor3ntin added a comment. Remove WS changes and cleanup tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106302/new/ https://reviews.llvm.org/D106302 Files: clang/lib/Sema/SemaExpr.cpp clang/te

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

aaron.ballman added inline comments. Comment at: clang/test/CXX/basic/basic.def.odr/p2-typeid.cpp:53-62 +consteval T *make_t() { return new T; } + +void func() { + (void)typeid(*null_s()); + (void)typeid(*make_s()); + (void)typeid(*null_t()); // expected-warning {{expression w

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin marked 2 inline comments as done. cor3ntin added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:612 +static_assert(is_same::value); + +} // namespace unevaluated rsmith wrote: > cor3ntin wrote: > > aaron.ballman wrote: > > > cor3ntin

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin updated this revision to Diff 364606. cor3ntin added a comment. - Add tests for typeid All the tests suggested by Richard pass as expected without having to modify the implementation of type id itself! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

rsmith added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:612 +static_assert(is_same::value); + +} // namespace unevaluated cor3ntin wrote: > aaron.ballman wrote: > > cor3ntin wrote: > > > cor3ntin wrote: > > > > aaron.ballman wrote: > > >

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin added a comment. @rsmith Ping again! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106302/new/ https://reviews.llvm.org/D106302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:612 +static_assert(is_same::value); + +} // namespace unevaluated aaron.ballman wrote: > cor3ntin wrote: > > cor3ntin wrote: > > > aaron.ballman wrote: > > > > Here's an interestin

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:612 +static_assert(is_same::value); + +} // namespace unevaluated cor3ntin wrote: > cor3ntin wrote: > > aaron.ballman wrote: > > > Here's an interesting test case: > > > ``` >

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:612 +static_assert(is_same::value); + +} // namespace unevaluated cor3ntin wrote: > aaron.ballman wrote: > > Here's an interesting test case: > > ``` > > #include > > > > struct

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:612 +static_assert(is_same::value); + +} // namespace unevaluated aaron.ballman wrote: > Here's an interesting test case: > ``` > #include > > struct S { > virtual void f(); >

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin updated this revision to Diff 360235. cor3ntin added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106302/new/ https://reviews.llvm.org/D106302 Files: clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/cxx2a-cons

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:603 + +long f(); //expected-note {{declared here}} +auto consteval g(auto a) { Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:608 + +auto e = g(f()); /

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin added a comment. Note that I think this was partially implemented as part of https://reviews.llvm.org/D74130 - which has not progressed since October. This PR implements P1937 only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D106302: Implement P1937 consteval in unevaluated contexts

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In an unevaluated contexts, consteval functions should not be immediately evaluated. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/