[PATCH] D106215: Make wide multi-character character literals ill-formed

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've landed in bdeda959abd74c88a6cfc34b10c1b665cb45cb8d Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but going to wait a bit to land it in case @rsmith has opinions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106215/new/ h

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

cor3ntin updated this revision to Diff 366317. cor3ntin added a comment. Describe this change in the changelog. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106215/new/ https://reviews.llvm.org/D106215 Files: clang/docs/ReleaseNotes.rst clang

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

cor3ntin updated this revision to Diff 366316. cor3ntin added a comment. Rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106215/new/ https://reviews.llvm.org/D106215 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/lib/Lex/L

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

aaron.ballman added a comment. I'm okay with the changes, but I think we should call this out in the release notes as there's technically the potential for this to be a breaking change (in both C and C++). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

cor3ntin updated this revision to Diff 366279. cor3ntin added a comment. Make wide multi char ill-formed regardless of language mode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106215/new/ https://reviews.llvm.org/D106215 Files: clang/include/

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

aaron.ballman added a comment. In D106215#2943675 , @cor3ntin wrote: > In D106215#2943653 , @aaron.ballman > wrote: > >> In D106215#2943631 , @cor3ntin >> wrote: >> >>>

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

cor3ntin marked an inline comment as done. cor3ntin added a comment. In D106215#2943653 , @aaron.ballman wrote: > In D106215#2943631 , @cor3ntin > wrote: > >> In D106215#2943611

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

cor3ntin marked an inline comment as done. cor3ntin added inline comments. Comment at: clang/test/CodeGen/string-literal-short-wstring.c:17 // MSABI: linkonce_odr dso_local unnamed_addr constant [3 x i16] [i16 65, i16 66, i16 0] - const wchar_t *foo = L"AB"; + const unsigne

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

cor3ntin updated this revision to Diff 366265. cor3ntin added a comment. Improve tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106215/new/ https://reviews.llvm.org/D106215 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/lib/

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

aaron.ballman added a comment. In D106215#2943631 , @cor3ntin wrote: > In D106215#2943611 , @aaron.ballman > wrote: > >> I think that C and C++ should behave the same here; at least, I don't see >> any reason wh

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

cor3ntin added a comment. In D106215#2943611 , @aaron.ballman wrote: > I think that C and C++ should behave the same here; at least, I don't see any > reason why they should have different capabilities. I agree but as WG14 hasn't weighted in I didn't w

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

aaron.ballman added a comment. I think that C and C++ should behave the same here; at least, I don't see any reason why they should have different capabilities. The paper said that there is no expected code breakage from this change, but have you tried building a diverse corpus of code (like a

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

cor3ntin updated this revision to Diff 359559. cor3ntin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106215/new/ https://reviews.llvm.org/D106215 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/lib/Lex/Lit

[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements P2362 , which has not het been approved by the C++ committee, but because wide-multi character literal