sammccall added a comment.
Sorry, forgot to address the style comments. Will send a followup patch.
Comment at: clang-tools-extra/clangd/Preamble.cpp:87
+
+const SourceManager &SM = CI.getSourceManager();
+const FileEntry *MainFE = SM.getFileEntryForID(SM.getMainFileID(
This revision was automatically updated to reflect the committed changes.
Closed by commit rG69c04ef95a35: [clangd] Propagate header-guarded flag from
preamble to main AST (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D106203?vs=359499&id=360093#toc
Repository:
r
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks!
Comment at: clang-tools-extra/clangd/Preamble.cpp:87
+
+const SourceManager &SM = CI.getSourceManager();
+const FileEntry *MainFE = SM.getFileEntryForID(S
sammccall updated this revision to Diff 359499.
sammccall added a comment.
revert unintended change
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106203/new/
https://reviews.llvm.org/D106203
Files:
clang-tools-extra/clangd/ParsedAST.cpp
clang-
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Fixes https://github.com/clan